Implement CI #3
Merged
Implement CI #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knazarov
approved these changes
Sep 3, 2024
AndreyMlashkin
force-pushed
the
fix_ci
branch
from
2a4477e to
3ba608b
Compare
AndreyMlashkin
force-pushed
the
master
branch
5 times, most recently
from
d145978 to
8242b5e
Compare
AndreyMlashkin
force-pushed
the
fix_ci
branch
from
314db3c to
d1b7165
Compare
akokoshn
reviewed
Sep 4, 2024
crypto3/crypto3.nix
Outdated
| @@ -33,6 +31,7 @@ in stdenv.mkDerivation { | |||
| (if enableDebug then "-DCMAKE_BUILD_TYPE=Debug" else "-DCMAKE_BUILD_TYPE=Release") | |||
| (if enableDebug then "-DCMAKE_CXX_FLAGS=-ggdb" else "") | |||
There was a problem hiding this comment.
let's keep CXX flags in CMake (like in zkEVMFramework)
| fetch-depth: 0 | ||
|
|
||
| - name: Run checks | ||
| run: nix build -L .?#checks.x86_64-linux.all-gcc |
There was a problem hiding this comment.
why only build without check?
There was a problem hiding this comment.
There are two chains to build now - gcc and clang.
It would take too long to build all. I would prefer to start 2 different jobs, so the CI will run faster
AndreyMlashkin
force-pushed
the
fix_ci
branch
from
7ff2add to
b0da678
Compare
akokoshn
approved these changes
Sep 5, 2024
AndreyMlashkin
pushed a commit
that referenced
this pull request
Sep 9, 2024
Poseidon support provided #2
AndreyMlashkin
added a commit
that referenced
this pull request
Sep 9, 2024
…ntainers Directly include parallel containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.